Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: check column data when execute alter table/column charset #34534

Closed
wants to merge 18 commits into from
Closed

ddl: check column data when execute alter table/column charset #34534

wants to merge 18 commits into from

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented May 10, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #34562

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

An error will be reported when executing a alter charset statement with invalid data.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 10, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 10, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/da6dfb80a308ae845b4bbf5a534a99d6dc448f46

@Defined2014 Defined2014 changed the title [WIP] ddl: support check column data when execute alter table/column charset ddl: check column data when execute alter table/column charset May 11, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 11, 2022
@Defined2014
Copy link
Contributor Author

/run-check-issue-triage-complete

@hawkingrei hawkingrei self-requested a review May 13, 2022 06:08
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 16, 2022
tangenta
tangenta reviewed May 16, 2022
View reviewed changes
ddl/column.go Outdated Show resolved Hide resolved
ddl/column.go Outdated Show resolved Hide resolved
parser/go.mod Outdated Show resolved Hide resolved
zimulala
zimulala reviewed May 16, 2022
View reviewed changes
ddl/table.go Outdated Show resolved Hide resolved
tangenta
tangenta reviewed May 16, 2022
View reviewed changes
ddl/column.go Outdated Show resolved Hide resolved
zimulala
zimulala reviewed May 17, 2022
View reviewed changes
ddl/table.go Outdated Show resolved Hide resolved
zimulala
zimulala approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 17, 2022
@Defined2014
Copy link
Contributor Author

This is not a good implementation, close it first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@zimulala zimulala zimulala approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support check invalid utf8 characters during Alter table ... charset stmts
6 participants
@Defined2014 @ti-chi-bot @sre-bot @hawkingrei @zimulala @tangenta